-
Notifications
You must be signed in to change notification settings - Fork 1
Improve permission checks in DemographicsService #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
labkey-jeckels
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
This is, generally, not a safe way to backport a change. If PR were to get merged to 22.3 with a merge commit, the "Fix merge conflicts" change would make a bunch of unwanted changes when we next merge forward to develop, likely breaking the build. Alternatively, you could run this to clean up the PR and eliminate any possible confusion: |
|
Correction: I didn't realize that this change was coming from the bimberlabkeyinternal fork. My git command might be wrong depending on which remote is "origin" in your enlistment |
@labkey-jeckels I restored the same branch I just merged into develop, renamed, and opened this PR. since it's the same commits, this should work OK with LabKey's merge process, right?