Skip to content

Conversation

@bbimber
Copy link
Collaborator

@bbimber bbimber commented May 26, 2022

@labkey-jeckels I restored the same branch I just merged into develop, renamed, and opened this PR. since it's the same commits, this should work OK with LabKey's merge process, right?

Copy link

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bbimber thanks, you beat me to creating the branch and PR.

I think this should be OK but would appreciate a quick sanity check from Trey who is savvier than me for these merges.

Trey, our primary goal here is to pick up up this commit:

68d437d

The other updates look fine to include too.

@labkey-tchad
Copy link
Member

labkey-tchad commented May 26, 2022

This is, generally, not a safe way to backport a change. If PR were to get merged to 22.3 with a merge commit, the "Fix merge conflicts" change would make a bunch of unwanted changes when we next merge forward to develop, likely breaking the build.
That is all to say, be extra-super-careful to choose "Squash and merge" when you merge this.

Alternatively, you could run this to clean up the PR and eliminate any possible confusion:

git checkout 22.3_fb_permissions
git reset --hard origin/release22.3-SNAPSHOT
git cherry-pick 68d437d
git push --force

@labkey-tchad
Copy link
Member

Correction: I didn't realize that this change was coming from the bimberlabkeyinternal fork. My git command might be wrong depending on which remote is "origin" in your enlistment

@labkey-jeckels labkey-jeckels merged commit d9dd395 into release22.3-SNAPSHOT May 26, 2022
@labkey-jeckels labkey-jeckels deleted the 22.3_fb_permissions branch May 26, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants